Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix already refers warnings in Clojure 1.11 #348

Closed
4 tasks done
skylee03 opened this issue Nov 21, 2023 · 0 comments · Fixed by #352
Closed
4 tasks done

Fix already refers warnings in Clojure 1.11 #348

skylee03 opened this issue Nov 21, 2023 · 0 comments · Fixed by #352
Assignees
Labels
enhancement New feature or request

Comments

@skylee03
Copy link
Collaborator

skylee03 commented Nov 21, 2023

WARNING: abs already refers to: #'clojure.core/abs in namespace: taoensso.encore, being replaced by: #'taoensso.encore/abs
WARNING: abs already refers to: #'clojure.core/abs in namespace: zero-one.geni.core.functions, being replaced by: #'zero-one.geni.core.functions/abs
WARNING: cat already refers to: #'clojure.core/cat in namespace: net.cgrand.parsley.fold, being replaced by: #'net.cgrand.parsley.fold/cat
WARNING: abs already refers to: #'clojure.core/abs in namespace: tech.v3.datatype.functional, being replaced by: #'tech.v3.datatype.functional/abs
WARNING: infinite? already refers to: #'clojure.core/infinite? in namespace: tech.v3.datatype.functional, being replaced by: #'tech.v3.datatype.functional/infinite?
WARNING: random-uuid already refers to: #'clojure.core/random-uuid in namespace: tech.v3.io.uuid, being replaced by: #'tech.v3.io.uuid/random-uuid

Updating dependencies can resolve some of these warnings, but updating them all may introduce new conflicts.

The second warning can be solved in Geni's code.

What we need to do:

  • Upgrade dependencies to versions where these warnings are solved
    • com.taoensso/nippy from 3.1.1 to 3.3.0
    • techascent/tech.ml.dataset from 5.21 to 6.101
      • Newer versions of TMD will introduce some new warnings.
        Reflection warning, ham_fisted/api.clj:1144:12 - call to method expireAfterAccess on com.google.common.cache.CacheBuilder can't be resolved (no such method).
        Reflection warning, ham_fisted/api.clj:1146:12 - call to method expireAfterWrite can't be resolved (target class is unknown).
        Reflection warning, ham_fisted/api.clj:1148:12 - reference to field softValues can't be resolved.
        Reflection warning, ham_fisted/api.clj:1150:12 - reference to field weakValues can't be resolved.
        Reflection warning, ham_fisted/api.clj:1152:12 - call to method maximumSize can't be resolved (target class is unknown).
        Reflection warning, ham_fisted/api.clj:1154:12 - reference to field recordStats can't be resolved.
        
    • midje from 1.10.3 to 1.10.9
    • Fixed in Fix already refers warnings in Clojure 1.11 #352
  • Exclude abs in src/clojure/zero_one/geni/core.clj
  • Exclude abs in src/clojure/zero_one/geni/core/functions.clj
  • Wait for some dependencies to solve their own issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant