Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abs already refers warning for CLJ1.11 #342

Merged
merged 1 commit into from
May 5, 2022

Conversation

pragyanatvade
Copy link
Contributor

No description provided.

@anthony-khong
Copy link
Member

Hey @heypragyan, thanks for this! Are you using the Geni Clojars? Do you need this bug fix to be released?

@anthony-khong anthony-khong merged commit b616f02 into zero-one-group:develop May 5, 2022
@pragyanatvade
Copy link
Contributor Author

Yes, I am using it from Clojars. If more changes need to be accommodated in the next release, I am okay with the warning.

@skylee03
Copy link
Collaborator

This problem is not fully fixed. In our code, we should also exclude abs in src/clojure/zero_one/geni/core/functions.clj. Besides, there are also some related warnings caused by our dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants