-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added collect-to-arrow support #284
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #284 +/- ##
==============================================
- Coverage 100.000% 99.778% -0.222%
==============================================
Files 36 37 +1
Lines 3050 3162 +112
Branches 0 7 +7
==============================================
+ Hits 3050 3155 +105
- Partials 0 7 +7
|
Thank you for the PR! This looks great! Let me review the code 😄 |
docker/project.clj
Outdated
:profiles | ||
{:provided {:dependencies ~spark-deps} | ||
:uberjar {:aot :all :dependencies ~spark-deps} | ||
:dev {:dependencies [[enlive "1.1.6"] | ||
[midje "1.9.9"]] | ||
[midje "1.9.9"] | ||
[techascent/tech.ml.dataset "5.00-alpha-19"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this one should go to provided dependencies too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having it in profile "dev" is not enough ?
This makes sure, is does not gets pulled in using geni.
I addressed most of your points, thanks for comments. I left function typed-action as-is. |
refactored more data types and refactored more data types and refactored make use of type hints added docstring clean up adapted to latest upstream coomit auto-changing file
99e78e8
to
1d246a8
Compare
091630b
to
33444c2
Compare
I merged manually all your cosmetic changes. |
Please have a look and lt me know, if fine. |
…into anthony-khong-collect_arrow
Hi @behrica, I believe this is good to merge! Just one final thing to pass the CI jobs:
Then it should be good! Thank you for the awesome PR, this is a great addition to the library! |
Should I write some lines here: to explain the different options Geni gives to "collect" data to the driver ? We could mention as well, that there is now tight integration with TMD, as an other form to "collect" data to work with it further. |
I added some docu , please have a look |
Great! It's looking good! I'll merge as soon as the pipeline passes. As for the docs, I suppose it's good to have. When we add TMD support in Geni, we should be able to do TMD-Spark interop from within Geni (i.e. no extra requires). When that happens, we just change the doc! Again, thank you so much for this PR!! |
refactored
more data types and refactored
more data types and refactored
make use of type hints
added docstring
clean up
adapted to latest upstream
coomit auto-changing file