Fix bug where g/->dataset doesn't work for more than 8 columns #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Problem / Steps to reproduce
Many apologies, I introduced a bug in #336 where
g/->dataset
loses order of the values when there are more than 8 columns:leads to
Expected Result
g/collect
should return the same output as the one we provided tog/->dataset
Proposed Solution
Dont use
zipmap
ingeni/src/clojure/zero_one/geni/core/dataset_creation.clj
Line 238 in b7323bd
Background
col-names
anymore