Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more NPCs in sinks, restrooms, and counch table in map_start #89

Merged
merged 3 commits into from
Oct 5, 2024

Conversation

AnhChienVu
Copy link
Contributor

@AnhChienVu AnhChienVu commented Oct 5, 2024

Part of #3
Hi @r4pt0s , I already added more NPCs to the start map by adding a randNpcsOnRestroomSinkCounch.gameObject.js file under src/gameObjects/map_start folder:

  • 2 in the sinks
  • 2 in the couch tables
  • 3 in the restrooms
    I was trying to create a custom NPC, but I see that it needs more time to dig deep into your project. If you don't mind, I can create another issue for custom NPCs with their specific roles and transcripts. I will try to work on that later

Copy link

🙏 Thanks for your pull request @AnhChienVu, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
89 91 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 22 54

Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

Copy link

🙏 Thanks for your pull request @AnhChienVu, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
89 91 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 22 55

Copy link

🙏 Thanks for your pull request @AnhChienVu, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
89 91 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 22 55

Copy link

🙏 Thanks for your pull request @AnhChienVu, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
89 91 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 22 55

1 similar comment
Copy link

🙏 Thanks for your pull request @AnhChienVu, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
89 91 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 22 55

@r4pt0s r4pt0s merged commit e59a192 into zero-to-mastery:main Oct 5, 2024
1 check passed
@r4pt0s
Copy link
Collaborator

r4pt0s commented Oct 5, 2024

@AnhChienVu merged and 🚀.
Thanks for adding more life to the map🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants