Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TriggerEvaluator #93

Closed
2 tasks done
zero88 opened this issue Dec 14, 2023 · 0 comments · Fixed by #95 or #99
Closed
2 tasks done

Add TriggerEvaluator #93

zero88 opened this issue Dec 14, 2023 · 0 comments · Fixed by #95 or #99
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@zero88
Copy link
Owner

zero88 commented Dec 14, 2023

Is your feature request related to a problem? Please describe.
Extract the logic to check the trigger is able to run or stop by condition to TriggerEvaluator
That makes easier to inject custom check into scheduler API from the application side.

Describe the solution you'd like

  • The Trigger Evaluator must be chained-able
  • The interface should be
interface TriggerEvaluator {

   Future<TriggerContext> shouldRun(...);

   Future<TriggerContext> shouldStop(...);
}
@zero88 zero88 added the enhancement New feature or request label Dec 14, 2023
@zero88 zero88 added this to the 2.0.0 milestone Dec 14, 2023
@zero88 zero88 self-assigned this Dec 14, 2023
zero88 added a commit that referenced this issue Dec 19, 2023
zero88 added a commit that referenced this issue Dec 27, 2023
zero88 added a commit that referenced this issue Dec 27, 2023
zero88 added a commit that referenced this issue Dec 27, 2023
zero88 added a commit that referenced this issue Dec 28, 2023
zero88 added a commit that referenced this issue Dec 28, 2023
fix(#93): the evaluation chaining operation must stop when reach a trigger target status
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant