Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ditch consumer groups for direct consumers #35

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

kalbhor
Copy link
Collaborator

@kalbhor kalbhor commented Nov 25, 2024

Apart from replacing cgs with direct consumer, this MR fixes the stop-at-end flag which wasn't functioning before

@kalbhor
Copy link
Collaborator Author

kalbhor commented Nov 26, 2024

Why replace consumer-groups:

  • We're not using the commit offset feature at all since all offsets are tracked in memory with initial value from the target topic
  • leaveAndResetOffsets seems to fail with UNKNOWN_TOPIC sometimes when a topic is reset causing the offsets to get out of sync
  • Direct consumers are easier to reason about and we do not have to care about rebalance scenarios

@knadh knadh merged commit 4273fc4 into zerodha:main Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants