Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kq sync producer write message wait 1s issue #76

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

MarkJoyMa
Copy link
Contributor

@MarkJoyMa MarkJoyMa commented Sep 12, 2024

Greptile Summary

This change addresses an issue with synchronous message pushing in the Kafka pusher, eliminating a 1-second delay problem.

  • Modified kq/pusher.go to set BatchSize to 1 when syncPush is true, ensuring immediate message sending without batching
  • Improves responsiveness for synchronous push operations in Kafka messaging
  • Resolves potential performance bottleneck for time-sensitive applications using synchronous push

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@kevwan kevwan merged commit 7e39254 into zeromicro:master Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants