fix: coredump: goctl model mysql ddl --src user_base.sql --dir . area… #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevwan
approved these changes
Dec 12, 2023
WqyJh
pushed a commit
to WqyJh/go-zero
that referenced
this pull request
Dec 21, 2023
zeromicro#3777) Co-authored-by: Kevin Wan <wanjunfeng@gmail.com>
dongmeng199
pushed a commit
to dongmeng199/go-zero
that referenced
this pull request
Dec 24, 2023
zeromicro#3777) Co-authored-by: Kevin Wan <wanjunfeng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/goctl #3766
Root cause:
when column name is not valid in UNIQUE KEY, element in uniqueIndex is nil in function checkDuplicateUniqueIndex() of parser.go file and crash happens
What is fixed
We don't add element to uniqueIndex when the column name of UNIQUE KEY is invalid.
When run command as following,
goctl model mysql ddl --src user_base.sql --dir .
and output below message and exit
"table %s: unique key with error column name[%s]"