Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): redis ttl -1 and -2 #3783

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Conversation

1067088037
Copy link
Contributor

Existing TTL functions cannot return -1 and -2.

@1067088037 1067088037 changed the title fix(redis): redis ttl < 0 fix(redis): redis ttl -1 and -2 Dec 12, 2023
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Merging #3783 (52bfd46) into master (ebe0801) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
core/stores/redis/redis.go 98.47% <100.00%> (+<0.01%) ⬆️

Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevwan kevwan added this pull request to the merge queue Dec 16, 2023
Merged via the queue into zeromicro:master with commit 4003864 Dec 16, 2023
6 checks passed
WqyJh pushed a commit to WqyJh/go-zero that referenced this pull request Dec 21, 2023
dongmeng199 pushed a commit to dongmeng199/go-zero that referenced this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants