Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: etcd scheme on grpc resolver #4121

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented May 6, 2024

  1. because resolver logic changed in grpc new versions
  2. after idle, grpc close the builder and call Build method again

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.09%. Comparing base (8690859) to head (7a970e7).
Report is 128 commits behind head on master.

Files Patch % Lines
zrpc/resolver/internal/discovbuilder.go 64.70% 6 Missing ⚠️
zrpc/resolver/internal/kubebuilder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
zrpc/resolver/internal/kubebuilder.go 16.07% <0.00%> (-4.69%) ⬇️
zrpc/resolver/internal/discovbuilder.go 51.42% <64.70%> (+12.96%) ⬆️

... and 253 files with indirect coverage changes

@kevwan kevwan marked this pull request as draft May 6, 2024 15:24
@kevwan kevwan marked this pull request as ready for review August 27, 2024 14:57
@kevwan kevwan merged commit 47d13e5 into zeromicro:master Aug 27, 2024
5 of 6 checks passed
@kevwan kevwan deleted the feat/resolver branch August 27, 2024 15:13
MarkJoyMa added a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant