Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tsgen): tsgen export buildTypes function #4197

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jaronnie
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (8690859) to head (5b569e1).
Report is 69 commits behind head on master.

Additional details and impacted files

see 255 files with indirect coverage changes

@kevwan
Copy link
Contributor

kevwan commented Jun 21, 2024

Why to export it? Would you please describe it in details?

@kevwan kevwan added area/api Categorizes issue or PR as related to API syntax or usages. area/goctl Categorizes issue or PR as related to goctl. labels Jun 25, 2024
@jaronnie
Copy link
Contributor Author

jaronnie commented Jul 14, 2024

image

Because I want to generate typescript sdk by api file, need generate ts model by this function.

export interface Empty {
}

export interface GetVersionResponse {
        version: string
        goVersion: string
        commit: string
        date: string
}

Copy link
Collaborator

@kesonan kesonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan added this pull request to the merge queue Jul 22, 2024
Merged via the queue into zeromicro:master with commit 6e08d47 Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Categorizes issue or PR as related to API syntax or usages. area/goctl Categorizes issue or PR as related to goctl.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants