Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support file server in rest #4244

Merged
merged 2 commits into from
Jul 13, 2024
Merged

feat: support file server in rest #4244

merged 2 commits into from
Jul 13, 2024

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Jul 12, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (8690859) to head (a6bdd12).
Report is 83 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
rest/internal/fileserver/filehandler.go 100.00% <100.00%> (ø)
rest/server.go 97.27% <100.00%> (+0.74%) ⬆️

... and 254 files with indirect coverage changes

@kevwan kevwan force-pushed the feat/file-server branch from 071ff6b to a6bdd12 Compare July 13, 2024 08:32
@zhoushuguang
Copy link
Collaborator

LGTM

@kevwan kevwan merged commit ec86f22 into zeromicro:master Jul 13, 2024
6 checks passed
@kevwan kevwan deleted the feat/file-server branch July 13, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevwan @zhoushuguang