Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ProcConf to make SetTimeToForceQuit configurable #4446

Merged
merged 1 commit into from
Jan 1, 2025
Merged

feat: add ProcConf to make SetTimeToForceQuit configurable #4446

merged 1 commit into from
Jan 1, 2025

Conversation

WqyJh
Copy link
Contributor

@WqyJh WqyJh commented Nov 4, 2024

Add ProcConf to ServiceConf, then we can use config file instead of SetTimeToForceQuit to set force quit time.

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (8690859) to head (362d858).
Report is 195 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
core/proc/shutdown.go 76.92% <100.00%> (+3.01%) ⬆️
core/service/serviceconf.go 90.32% <100.00%> (+0.32%) ⬆️

... and 8 files with indirect coverage changes

@WqyJh
Copy link
Contributor Author

WqyJh commented Nov 14, 2024

Could this simple patch be merged? @kevwan

@kevwan kevwan force-pushed the feat-graceful-shutdown branch from 54bae6e to 362d858 Compare January 1, 2025 07:10
@kevwan kevwan added this pull request to the merge queue Jan 1, 2025
Merged via the queue into zeromicro:master with commit 22a41ca Jan 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WqyJh @kevwan