Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Appveyor build is slow. #212

Merged
merged 9 commits into from
Apr 20, 2018
Merged

Conversation

kurdybacha
Copy link
Contributor

@kurdybacha kurdybacha commented Apr 20, 2018

Solution: use Appveyor caching for libzmq dependency

@bluca @sigiesec this is from appveyor website:

Note: By default, saving cache is disabled in Pull Request builds. Use Save build cache in Pull Requests checkbox on the General tab of project settings if you need to save cache during PR builds. This setting is not exposed in YAML to prevent unauthorized cache modifications.

@kurdybacha kurdybacha changed the title Appveyor cache Problem: Appveyor build is slow. Apr 20, 2018
@coveralls
Copy link

coveralls commented Apr 20, 2018

Pull Request Test Coverage Report for Build 52

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 56.25%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 3 64.38%
Totals Coverage Status
Change from base Build 42: 0.0%
Covered Lines: 36
Relevant Lines: 64

💛 - Coveralls

@bluca
Copy link
Member

bluca commented Apr 20, 2018

It doesn't seem to be making a difference? Can't see anything in the logs

@kurdybacha
Copy link
Contributor Author

If you have just enabled it maybe it will apply on next pull request? I am just guessing here as I can not find anything useful in the appveyor docs.

@bluca
Copy link
Member

bluca commented Apr 20, 2018

I'll kick it so it runs again

@bluca
Copy link
Member

bluca commented Apr 20, 2018

It seems to kick in after a rebuild but it fails:

Cache 'libzmq-4.2.5' - Restored
Running Install scripts
if not exist libzmq-%ZMQ_VERSION% ( appveyor DownloadFile https://github.com/zeromq/libzmq/archive/v%ZMQ_VERSION%.zip && 7z x v%ZMQ_VERSION%.zip >NUL && cmake -H./libzmq-%ZMQ_VERSION% -BBuild-libzmq -DENABLE_DRAFTS=ON -DWITH_PERF_TOOL=OFF -DZMQ_BUILD_TESTS=OFF -DENABLE_CPACK=OFF -A%PLATFORM% && cmake --build Build-libzmq && cmake -H. -BBuild -DCMAKE_PREFIX_PATH=./Build-libzmq -A%PLATFORM% )
Specified build project file or folder does not exist: "Build/cppzmq.sln"

@bluca
Copy link
Member

bluca commented Apr 20, 2018

It fails later now:

Build FAILED.
"C:\projects\cppzmq\Build\cppzmq.sln" (default target) (1) ->
"C:\projects\cppzmq\Build\ALL_BUILD.vcxproj.metaproj" (default target) (2) ->
"C:\projects\cppzmq\Build\tests\unit_tests.vcxproj.metaproj" (default target) (12) ->
"C:\projects\cppzmq\Build\tests\unit_tests.vcxproj" (default target) (13) ->
(ClCompile target) -> 
  c:\projects\cppzmq\zmq.hpp(51): fatal error C1083: Cannot open include file: 'zmq.h': No such file or directory [C:\projects\cppzmq\Build\tests\unit_tests.vcxproj]
  c:\projects\cppzmq\zmq.hpp(51): fatal error C1083: Cannot open include file: 'zmq.h': No such file or directory [C:\projects\cppzmq\Build\tests\unit_tests.vcxproj]
  c:\projects\cppzmq\zmq.hpp(51): fatal error C1083: Cannot open include file: 'zmq.h': No such file or directory [C:\projects\cppzmq\Build\tests\unit_tests.vcxproj]
  c:\projects\cppzmq\zmq.hpp(51): fatal error C1083: Cannot open include file: 'zmq.h': No such file or directory [C:\projects\cppzmq\Build\tests\unit_tests.vcxproj]
    0 Warning(s)
    4 Error(s)
Time Elapsed 00:00:24.11

@kurdybacha
Copy link
Contributor Author

Yes, I saw this on my branch already. I will investigate in the evening and let you know when fixed. sorry for this noise but it is pain to test this. Maybe I should cancel this pull request until it is fixed?

@bluca
Copy link
Member

bluca commented Apr 20, 2018

I don't mind, up to you

@kurdybacha
Copy link
Contributor Author

@bluca it should be fine now. After rebuild you should see more x2 speedup now. Still room to improve...

@bluca
Copy link
Member

bluca commented Apr 20, 2018

much better, thanks

@bluca bluca merged commit 82a7f76 into zeromq:master Apr 20, 2018
@kurdybacha kurdybacha deleted the appveyor_cache branch April 20, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants