Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message_t::routing_id() and set_routing_id() #235

Merged
merged 1 commit into from
May 20, 2018
Merged

Add message_t::routing_id() and set_routing_id() #235

merged 1 commit into from
May 20, 2018

Conversation

Tulon
Copy link
Contributor

@Tulon Tulon commented May 19, 2018

Setting a routing id is necessary when sending a message through a
ZMQ_SERVER socket. See [1] for more details.

This commit fixes #233.

[1] http://api.zeromq.org/4-2:zmq-socket#toc5

Setting a routing id is necessary when sending a message through a
ZMQ_SERVER socket. See [1] for more details.

[1] http://api.zeromq.org/4-2:zmq-socket#toc5
@coveralls
Copy link

coveralls commented May 19, 2018

Pull Request Test Coverage Report for Build 102

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+23.5%) to 78.182%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 2 64.1%
Totals Coverage Status
Change from base Build 95: 23.5%
Covered Lines: 129
Relevant Lines: 165

💛 - Coveralls

@Tulon
Copy link
Contributor Author

Tulon commented May 19, 2018

I am not quite sure why some CI builds fail. It looks like ZMQ_BUILD_DRAFT_API may be defined even though libzmq was built with draft APIs disabled.

@kurdybacha
Copy link
Contributor

kurdybacha commented May 19, 2018

@Tulon thank you for PR. I would be able to take a look in the evening (GMT). Maybe someone else can help in the meantime. I would suggest you try to use ci_build.sh locally. Just run ./ci_build.sh without any arguments as this is one of the failing use cases (assuming you have Linux box). Maybe you get more info.

@sigiesec
Copy link
Member

Hm, the poller stuff is additionally guarded by ZMQ_HAVE_POLLER, so maybe ZMQ_BUILD_DRAFT_API might really be always set. This might be an error on either the libzmq or our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft API methods need to be exposed
4 participants