Generalize arithmetic operators for socket_base and derived #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sigiesec
changed the title
gummif
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #469
As mentioned in the issue and the referred comment, this PR is in particular needed for the migration to Catch2, which exposed that these operators were not covering some cases (e.g.
socket_refvssocket_t).This generalization is based on polymorphism and improves const correctness, without exploiting custom cast operators of
socket_refandsocket_t(indeed, it is not so clear to me the situation of these conversion functions, and their const correctness).@gummif has for sure insight on this and may want to give a final feedback on this.