Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Windows Intel compiler build broken #2920

Merged
merged 1 commit into from
Feb 4, 2018

Conversation

tetsuh
Copy link

@tetsuh tetsuh commented Feb 3, 2018

Problem: #2919 Windows Intel compiler build error by include zmq.h

Solution:
Modified ifdef condition order of typedef struct zmq_msg_t alignement.
Placed if defined(_MSC_VER) before the other compiler.

@tetsuh tetsuh changed the title fix Windows Intel compiler build broken Problem: Windows Intel compiler build broken Feb 3, 2018
@bluca
Copy link
Member

bluca commented Feb 4, 2018

Thanks!

@bluca bluca merged commit c43c879 into zeromq:master Feb 4, 2018
@bluca
Copy link
Member

bluca commented Feb 4, 2018

Sorry - have to temporarily revert, nothing to do with your changes but just to avoid merge conflicts in a fairly large style reformatting happening in #2908 - I will take care of re-applying your fix afterwards. Should not take long.

@tetsuh
Copy link
Author

tetsuh commented Feb 6, 2018

sure, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants