Fix gcc 8 build warning/error with -O3. #2960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a small build error/warning when building with gcc 8 and -O3 in CFLAGS/CXXFLAGS:
Here we don't actually need to call
strlen(group_)
, sincestrncpy
will already stop at the end of the string, and this is what gcc tries to complain about in his cryptic message. Replacing it with the maximum length that fits for a group silences the warning, and has the same end result, without computing the string length both instrlen
andstrncpy
.Cheers,
Romain