Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DragonFlyBSD] fix for IPv4 mapping not supported #3608

Merged
merged 2 commits into from
Aug 6, 2019
Merged

[DragonFlyBSD] fix for IPv4 mapping not supported #3608

merged 2 commits into from
Aug 6, 2019

Conversation

hxw
Copy link
Contributor

@hxw hxw commented Aug 6, 2019

On DragonFly the zmq::enable_ipv4_mapping in ip.cpp fais with a not supported error
So handle this case the same as for OpenBSD

Also update configure files to set the correct definitions for DragonFly OS

This includes all patches from the dports/net/libzmq/dragonfly patches directory

hxw added 2 commits August 6, 2019 12:11
solution: on DragonFly also define ZMQ_HAVE_FREEBSD
          in addition to ZMQ_HAVe_DRAGONFLY

Signed-off-by: Christopher Hall <hsw@ms2.hinet.net>
…hen IPv6 is used

solution: Handle as for OpenBSD by not attemption to set this option on the socket

Signed-off-by: Christopher Hall <hsw@ms2.hinet.net>
hxw referenced this pull request in DragonFlyBSD/DeltaPorts Aug 6, 2019
- Handle v4-mapping as for OpenBSD. DragonFly BSD does not allow mapping
  global IPv4 addresses when IPv6 is used.

Reported by: Christopher Hall (hxw) #208
@sigiesec sigiesec merged commit c3eab89 into zeromq:master Aug 6, 2019
@sigiesec
Copy link
Member

sigiesec commented Aug 6, 2019

Thanks a lot for the fix!

Please consider also adding a known user entry for DragonFly to https://github.com/zeromq/libzmq/blob/master/README.md

Thanks!

@bluca
Copy link
Member

bluca commented Aug 6, 2019

@hxw could you please send another PR with a relicense statement? As explained in https://github.com/zeromq/libzmq/blob/master/.github/CONTRIBUTING.md and https://github.com/zeromq/libzmq/tree/master/RELICENSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants