add ZMQ_PREFIX to $RPATH by default #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
old setup.py used to try to do this
This comment was marked as outdated.
This comment was marked as outdated.
delocate/auditwheel fix these
matches linux behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old setup.py used to try to do this, and it seems to solve some problems for folks who don't expect to have to set
LDFLAGS=-Wl,-rpath,$ZMQ_PREFIX/lib(#1976).Setting ZMQ_PREFIX now appends $ZMQ_PREFIX/lib to rpath via cmake. Same goes for libzmq found via search.