Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various failing tests #624

Merged
merged 11 commits into from
Jun 17, 2024
Merged

Fix various failing tests #624

merged 11 commits into from
Jun 17, 2024

Conversation

aminya
Copy link
Member

@aminya aminya commented Jun 15, 2024

No description provided.

@aminya aminya merged commit 44e061b into master Jun 17, 2024
6 checks passed
@aminya aminya deleted the tests branch June 17, 2024 17:41
@rotu
Copy link
Contributor

rotu commented Jun 17, 2024

I tried to give targeted and actionable feedback but it seems to have been ignored. @aminya, @bluca, in the spirit of open source, how can I better contribute to this project?

@aminya
Copy link
Member Author

aminya commented Jun 17, 2024

@rotu I think you have misread the code. I didn't remove the .gc calls. They were just indented. Changing the GC calls is out of the scope of this PR.

@rotu
Copy link
Contributor

rotu commented Jun 17, 2024

@rotu I think you have misread the code. I didn't remove the .gc calls. They were just indented. Changing the GC calls is out of the scope of this PR.

@aminya oops - you're right you didn't remove them. BTW, these calls make the garbage collector run synchronously, so if any of the tests are at all timing-sensitive, you might notice some weirdness, especially since things are running in parallel now.

@aminya
Copy link
Member Author

aminya commented Jun 17, 2024

@rotu Some of the remaining failing tests are related to GC, but we have to fix them. Take a look at Issue 466 for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants