smoke test #634
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -189,6 +189,7 @@ jobs: | |
| pnpm install -g electron@latest | ||
| xvfb-run --auto-servernum pnpm run test.electron.main | ||
| continue-on-error: true | ||
|
|
||
| merge-build: | ||
| runs-on: ubuntu-latest | ||
| needs: Build | ||
|
|
@@ -199,3 +200,53 @@ jobs: | |
| name: build | ||
| pattern: build-* | ||
| delete-merged: true | ||
|
|
||
|
|
||
| smoke-test: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: | ||
| - ubuntu-latest | ||
| - windows-latest | ||
| - macos-latest | ||
| pm: | ||
| - npm | ||
| - yarn | ||
| - pnpm | ||
| steps: | ||
| - uses: actions/setup-node@v4 | ||
| - run: | | ||
| npm init --init-module testproject -y | ||
|
There was a problem hiding this comment. You can use this template package and add an example test to it |
||
| npm pkg set dependencies.zeromq='${{ github.repositoryUrl }}#${{ github.ref }}' | ||
|
|
||
| - if: ${{ matrix.pm == 'npm' }} | ||
| run: | | ||
| npm install | ||
| env: | ||
| NPM_CONFIG_LOGLEVEL: verbose | ||
|
|
||
|
There was a problem hiding this comment. It would be great to run a simple example where zeromq is imported. This will ensure the runtime compatibility via the smoke test for different Nodejs versions. There was a problem hiding this comment. I was thinking of possibly co-opting https://github.com/zeromq/zeromq.js/blob/ea5f35ceef48a9847562d53f839b3ffb74956711/examples/package.json |
||
| - if: ${{ matrix.pm == 'pnpm' }} | ||
| run: | | ||
| npm install -g pnpm | ||
| pnpm install | ||
| env: | ||
| NPM_CONFIG_LOGLEVEL: verbose | ||
|
|
||
| - if: ${{ matrix.pm == 'yarn' }} | ||
| run: | | ||
| npm install -g yarn | ||
| yarn set version stable | ||
| yarn install | ||
| env: | ||
| YARN_ENABLE_IMMUTABLE_INSTALLS: false | ||
| YARN_ENABLE_INLINE_BUILDS: true | ||
| - uses: actions/upload-artifact@v4 | ||
| if: ${{ failure() && runner.os == 'Windows' }} | ||
| with: | ||
| name: logs-${{matrix.pm}}-${{runner.os}} | ||
| overwrite: true | ||
| path: | | ||
| C:\npm\cache\_logs\ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can include multiple versions such as
10, 12, 18, 22to ensure compatibility across different versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right and I'd like to get there before this is merged. As you can see from my embarrassing commit history, I'm not quite there yet...