Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build errors caused by purely namespaced enums and druation api changes #32

Merged
merged 4 commits into from
Nov 27, 2014
Merged

fix build errors caused by purely namespaced enums and druation api changes #32

merged 4 commits into from
Nov 27, 2014

Conversation

nanne007
Copy link
Contributor

  1. Switch to purely namespaced enums rust-lang/rust#18973 made a change to enum namespacing, which causes a build error.
  2. num::abs method no longer exists, use SignedInt.abs instead.
  3. Zero trait implementation for Duration is removed. Instead, use Duration.zero() directly.

@nanne007 nanne007 changed the title fix build errors caused by purely namespaced enums and druation trait changes fix build errors caused by purely namespaced enums and druation api changes Nov 26, 2014
@fantix
Copy link
Member

fantix commented Nov 27, 2014

That's neat! Thanks for the fix!

fantix added a commit that referenced this pull request Nov 27, 2014
@fantix
Merge pull request #32 from windor/build-error-fixed
f8a1361 
fix build errors caused by purely namespaced enums and druation api changes
@fantix fantix merged commit f8a1361 into zeromq:master Nov 27, 2014
@nanne007 nanne007 deleted the build-error-fixed branch November 27, 2014 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanne007 @fantix