Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/zerotier/libzt/issues/242 #243

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

bostick
Copy link
Contributor

@bostick bostick commented Aug 4, 2023

When processing events, AttachCurrentThread is called, but matching DetachCurrentThread was not being called

This prevented main thread from exiting

When processing events, AttachCurrentThread is called, but matching
DetachCurrentThread was not being called

This prevented main thread from exiting
@joseph-henry
Copy link
Contributor

Thank you. I really like that you included a test with the commit. I do think we should maybe combine it with the existing java selftest thouth and add some assertions at some point.

@joseph-henry joseph-henry merged commit 624038d into dev Aug 4, 2023
@bostick
Copy link
Contributor Author

bostick commented Aug 4, 2023

Yes. For adding to selftest, would recommend to launch a child process of java ExitTest and check that it terminates. i.e., not relying on the test harness process itself or running as separate thread inside the process.

@bostick bostick deleted the bugfix/242 branch August 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants