-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for breaking change in eslint v6+ #21
Conversation
Please, accept this PR |
This dependency was not update for last 2 years and it's currently blocking us, see: zertosh/eslint-plugin-dependencies#21 We don't need this plugin even if they merge the PR because 'import' plugin solves almost everything. kiwicom-source-id: 09c21ade25816dfb357c4c9598fb38281a0f0ce9
Better approach is to not rely on internal ESLint functions at all. See vuejs/eslint-plugin-vue#910 for comparison. |
Agreed. Are you making the change?
…On Fri, Sep 6, 2019 at 6:45 PM Gabe Gorelick ***@***.***> wrote:
Better approach is to not rely on internal ESLint functions at all. See
vuejs/eslint-plugin-vue#910
<vuejs/eslint-plugin-vue#910> for comparison.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21?email_source=notifications&email_token=AAHKXF2ETWGQKXFV42YCGEDQIJ3JRA5CNFSM4H3FWDMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DH2QI#issuecomment-528907585>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHKXF2XVVIALESO4GH3XUTQIJ3JRANCNFSM4H3FWDMA>
.
|
I would be happy to, but since there is no indication that any PR will get merged (none since 2017), I wasn't planning on it. See the (currently one-sided) discussion on #23. |
Yes, it does look abandoned. I gave up on this initiative a while ago
Doesn't seem like there will be any feedback any time soon
…On Fri, Sep 6, 2019 at 8:59 PM Gabe Gorelick ***@***.***> wrote:
I would be happy to, but since there is no indication that any PR will get
merged (none since 2017), I wasn't planning on it. See the (currently
one-sided) discussion on #23
<#23>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21?email_source=notifications&email_token=AAHKXF75IHK3NQVEDJNPA7LQIKK6BA5CNFSM4H3FWDMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DTEKI#issuecomment-528953897>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHKXF57DJGPPSS5COM4JN3QIKK6BANCNFSM4H3FWDMA>
.
|
I considered at some point doing a published fork, but give up when realised that the plugin Here are the equivalent rules:
Here is the list of all the rules: https://github.com/benmosher/eslint-plugin-import#rules |
☝️ that could interest you too @pladaria :) and also everyone that 👍 the issues and comment |
|
@AdrieanKhisbe We did exactly the same long time ago! 👍 |
@AdrieanKhisbe sadly We finally did an internal fork of this plugin |
@pladaria, would this fix your issue? |
@zertosh - Hi can you you please approve and merge this PR? theres a breaking change due to folder restructuring from eslint version updates |
Published as 2.5.0 |
No description provided.