Workaround for loading ESM #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial workaround for loading files with ESM imports.
This works by adding the
importModuleDynamicallyoption invm.Scriptconstructor, which is required when the script has dynamicsimports(). In this case, the cache is also disabled because otherwise it would throw "Invalid host defined options" (I wasn't able to find out why).I've added a couple benchmark cases, all of them are working with Node 10 and 18.
I'm not familiar with Node
vmlogic. This said, I believe this change only affects required files with ESM imports, which are not working at all now, so it shouldn't have side effects for other cases.Edit: fixes #41