-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrige la gestion des unes #4450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motet-a
approved these changes
Aug 6, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mais j’ai pas lu les sources.
NOK : dans certains cas de modifications la une est dupliquée |
motet-a
reviewed
Aug 9, 2017
@@ -45,6 +46,7 @@ | |||
class="topic-image" | |||
> | |||
<span class="topic-title">{{ featured_resource.title }}</span> | |||
<span class="topic-subtitle">{% trans 'Publiée' %} {{ featured_resource.pubdate|format_date:True|lower }}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je verrais mieux ça avec des retours à la ligne :
<span class="topic-subtitle">
{% trans 'Publiée' %}
{{ featured_resource.pubdate|format_date:True|lower }}
</span>
sandhose
pushed a commit
that referenced
this pull request
Sep 18, 2017
* Corrige la gestion des unes (fix #4444) * CBV that! * Ajoute un input type="datetime-local"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: plus de formats de date supportés, en ce compris le traditionel
d/m/Y H:M
(mais d'autres, et l'ancien, fonctionnent toujours)Note: en fait, régler #3605 est un peu plus tordu que prévu, parce que c'est une fonctionnalité qui n'est supporté aujourd'hui que par chrome (même si les autres suivent). Du coup, ça donne un format de date un peu bizarre pour ceux qui utilisent un navigateur moins récent.
QA