Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppression de jquery du fichier close-alert-box.js #5969

Merged
merged 4 commits into from
Dec 17, 2020
Merged

suppression de jquery du fichier close-alert-box.js #5969

merged 4 commits into from
Dec 17, 2020

Conversation

firm1
Copy link
Contributor

@firm1 firm1 commented Oct 11, 2020

Cette PR supprime jquery du fichier close-alert-box.js

Numéro du ticket concerné (optionnel) : #5786

Contrôle qualité

  • Avant de lancer le site make run-back assurez-vous d'avoir buildé le front make build-front
  • Lancez le site make run-back
  • Vérifiez les endroits ou cette fonction est utilisée sur le site às avoir:
    • fermer la boite d'alerte dans l'éditeur de texte qui présente l'aide markdown
    • fermer les boîtes d'alertes qui surviennent par exemple lorsqu'on réserve un tutoriel

Capture d’écran de 2020-10-11 22-32-23
Capture d’écran de 2020-10-11 22-32-39

AmauryCarrade
AmauryCarrade requested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@AmauryCarrade AmauryCarrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça fonctionne en l'état mais j'apprécierais que le code soit amélioré, au niveau des commentaires qui ont été fait sur le setTimeout.

@firm1
Copy link
Contributor Author

firm1 commented Nov 7, 2020

Du coup j'ai pris en compte vos remarques, j'ai opté pour l'option 3 de @AmauryCarrade qui me parait plus efficace niveau maintenance et vieillissement du code.

@coveralls
Copy link

coveralls commented Dec 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 86.856% when pulling 142979c on firm1:vanilla_js_close_alert into a154d02 on zestedesavoir:dev.

Situphen
Situphen approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK !

@Situphen Situphen merged commit 7dbd58e into zestedesavoir:dev Dec 17, 2020
viki53 pushed a commit to viki53/zds-site that referenced this pull request Jul 7, 2022
@firm1 @Situphen @viki53
suppression de jquery du fichier close-alert-box.js (zestedesavoir#5969)
8f60615 
* migrate to vanilla js close alert box.js

* remove setTimeout

Co-authored-by: Situphen <Situphen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artragis artragis artragis left review comments

@AmauryCarrade AmauryCarrade AmauryCarrade requested changes

@Situphen Situphen Situphen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@firm1 @coveralls @AmauryCarrade @artragis @Situphen