Ajoute des tests à AddContributor #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnaud-D
added
C-Back
10 tasks
Arnaud-D
force-pushed
the
contribute_to_tests_again
branch
from
686a98c
to
8f580aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans la lignée de #6193. Cette PR rajoute des tests pour la vue
AddContributor.Je n'ai pas changé du tout le comportement de la vue en elle-même, donc les tests unitaires devraient suffire. La vue n'était pas testée avant, et ça m'a fait remarquer quelques excentricités qui pourront être refactorisée un jour. ^^
Contrôle qualité
Le passage des tests unitaires devrait suffire, parce que je n'ai pas du tout touché au code de la vue.
Une revue de code est la bienvenue (mais bon, c'est du code de test, pas le niveau maximal d'intérêt :D ).