Vérifie qu'il ne manque pas de migrations dans la CI #6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Situphen
requested changes
Feb 5, 2022
Co-authored-by: Situphen <Situphen@users.noreply.github.com>
Situphen
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pour faire suite à la suggestion de @Situphen dans la PR #6231, cette PR ajoute une étape dans la CI qui vérifie qu'il ne manque pas de migration de la base de données, et échoue le cas échéant.
Cette PR ne passera pas la CI, puisqu'il manque actuellement une migration dans le code, corrigé dans la PR de Situphen.
J'ai testé les changements en pushant une fois avec puis sans la migration manquante, ça se comporte bien comme on le souhaite.
En terme de QA, juste faire une petite revue de code (et me faire confiance quand je dis que ça fonctionne ! :D ).