Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remplace notre implémentation de LoginRequiredMixin par celle de Django #6252

Merged

Conversation

Arnaud-D
Copy link
Contributor

Un des items de #6246.

Une partie de notre code utilisait déjà l'implémentation de Django, donc ça ne fait qu'éliminer de vieilles miettes.

Contrôle qualité

En tant que visiteur non logué, vérifier qu'on est bien redirigé vers le login quand on utilise une page qui nécessite le login pour y accéder.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 87.165% when pulling ef7abda on Arnaud-D:back_to_the_future_login_required into 46d3ff1 on zestedesavoir:dev.

Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rapport de QA

OK ✔️

@philippemilink philippemilink merged commit b357482 into zestedesavoir:dev Mar 3, 2022
@Arnaud-D Arnaud-D deleted the back_to_the_future_login_required branch March 5, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants