Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remplace notre implémentation de PermissionRequiredMixin par celle de Django #6262

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Remplace notre implémentation de PermissionRequiredMixin par celle de Django #6262

merged 1 commit into from
Mar 23, 2022

Conversation

Arnaud-D
Copy link
Contributor

Un des items de #6246

Contrôle qualité

Les tests unitaires font le gros du boulot a priori (si tant est qu'on ait les bons tests ;-) ).

Sinon, tester manuellement vite fait que le workflow de validation marche toujours comme prévu.

@Arnaud-D Arnaud-D added C-Back Concerne le back-end Django S-Refactorisation Améliore le code existant sans forcément ajouter de nouvelle fonctionnalité labels Mar 19, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 87.32% when pulling 84cd72b on Arnaud-D:permission_required into 0035c93 on zestedesavoir:dev.

Situphen
Situphen approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK J'ai testé un peu en local sans rencontrer de soucis et Github Actions est vert donc je fusionne !

@Situphen Situphen merged commit 6628882 into zestedesavoir:dev Mar 23, 2022
@Arnaud-D Arnaud-D deleted the permission_required branch March 24, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Situphen Situphen Situphen approved these changes

Assignees
No one assigned
Labels
C-Back Concerne le back-end Django S-Refactorisation Améliore le code existant sans forcément ajouter de nouvelle fonctionnalité
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arnaud-D @coveralls @Situphen