Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Export PDF) Enlève les conteneurs non validés #6267

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

Situphen
Copy link
Member

Les conteneurs avec ready_to_publish à False ne sont plus inclus dans l'export LaTeX et PDF des contenus publiés.

Corrige un des soucis de #6265

QA :

  • source zdsenv/bin/activate && make update && make zmd-start && make run-back
  • Télécharger l'archive du contenu Un zeste de Python
  • Créer un nouveau tutoriel à partir de cette archive et le valider
  • Dans un nouvel onglet de votre terminal, lancer source zdsenv/bin/activate puis python manage.py publication_watchdog
  • Ouvrir l'export LaTeX et/ou PDF généré
  • Vérifier que les conteneurs non validés n'apparaissent pas dedans (par exemple, « Plusieurs tâches en même temps »)

@coveralls
Copy link

coveralls commented Mar 23, 2022

Coverage Status

Coverage increased (+0.002%) to 87.202% when pulling 2c18381 on Situphen:ready-to-publish-latex into f8d2136 on zestedesavoir:dev.

philippemilink
philippemilink previously approved these changes Mar 27, 2022
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rapport de QA

Testé manuellement, ça fonctionne.

J'ai complété le test pour s'assurer aussi que le fichier tex ne contient que les parties prêtes à être publiées. Si ça te convient @Situphen, on merge.

Copy link
Member Author

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai eu un peu de mal à comprendre le code donc je propose ces modifications sur les commentaires. À part cela, c'est OK pour moi !

zds/tutorialv2/tests/tests_utils.py Outdated Show resolved Hide resolved
zds/tutorialv2/tests/tests_utils.py Show resolved Hide resolved
zds/tutorialv2/tests/tests_utils.py Outdated Show resolved Hide resolved
zds/tutorialv2/tests/tests_utils.py Outdated Show resolved Hide resolved
Situphen and others added 3 commits March 28, 2022 22:59
Suite à la revue de code de Situphen.

Co-authored-by: Situphen <Situphen@users.noreply.github.com>
@philippemilink philippemilink enabled auto-merge (squash) March 28, 2022 21:01
@philippemilink philippemilink merged commit b00a78d into zestedesavoir:dev Mar 28, 2022
@Situphen Situphen deleted the ready-to-publish-latex branch March 28, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants