Refactorise les URL du forum #6295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnaud-D
added
C-Back
Arnaud-D
force-pushed
the
passez_votre_chemin_refacto_urls_en_cours_4
branch
from
6a4e289
to
431e2b8
Compare
Arnaud-D
force-pushed
the
passez_votre_chemin_refacto_urls_en_cours_4
branch
from
431e2b8
to
35eb87a
Compare
philippemilink
requested changes
Jul 3, 2022
There was a problem hiding this comment.
La revue de code est OK, mais quand on va sur le profil d'un utilisateur :
NoReverseMatch at /@admin
Reverse for 'topic-find' not found. 'topic-find' is not a valid view function or pattern name.
Et en effet les tests sur la vue du profil d'un membre semblent un peu léger (la page de profil n'a pas grand chose à afficher, donc une bonne partie du template n'est pas traitée, par exemple les topics du membre).
Arnaud-D
force-pushed
the
passez_votre_chemin_refacto_urls_en_cours_4
branch
from
b614f6a
to
446fd63
Compare
|
J'ai corrigé l'oubli. Je ne souhaite pas rajouter de tests dans cette PR parce que ça fait grossier le scope au-delà de ce que je suis prêt à faire. Ta remarque pourrait peut-être faire l'objet d'un ticket de refactorisation ? |
Arnaud-D
force-pushed
the
passez_votre_chemin_refacto_urls_en_cours_4
branch
from
446fd63
to
6a83d67
Compare
|
Désolé, le merge n'était pas aussi simple. Il faut mettre à jour les routes dans certains tests : |
Arnaud-D
force-pushed
the
passez_votre_chemin_refacto_urls_en_cours_4
branch
from
0aa5fd5
to
4efcc63
Compare
Arnaud-D
force-pushed
the
passez_votre_chemin_refacto_urls_en_cours_4
branch
from
4efcc63
to
cb4c36c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lié à #6246.
Au menu de cette refacto des URL du forum :
Contrôle qualité
Vérifier que les forums continuent de fonctionner nominalement (juste exercer toutes les routes).