Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorise les URL de recherche #6299

Merged
merged 2 commits into from
Jul 3, 2022
Merged

Refactorise les URL de recherche #6299

merged 2 commits into from
Jul 3, 2022

Conversation

Arnaud-D
Copy link
Contributor

@Arnaud-D Arnaud-D commented May 7, 2022

Lié à #6246.

Au menu de cette refacto des URL de recherche :

  • path au lieu de re_path
  • déplacement du namespace sous forme de "app_name" (c'est équivalent pour notre usage et plus local)

Contrôle qualité

Exercer les différentes routes de recherche du fichier urls.py.

@Arnaud-D Arnaud-D added C-Back Concerne le back-end Django S-Refactorisation Améliore le code existant sans forcément ajouter de nouvelle fonctionnalité labels May 7, 2022
@coveralls
Copy link

coveralls commented May 7, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 88.002% when pulling 2b3bb55 on Arnaud-D:passez_votre_chemin_refacto_urls_en_cours_8 into 40ff008 on zestedesavoir:dev.

@Arnaud-D Arnaud-D force-pushed the passez_votre_chemin_refacto_urls_en_cours_8 branch from dc4219d to a7b18fd Compare June 2, 2022 21:41
@Arnaud-D Arnaud-D force-pushed the passez_votre_chemin_refacto_urls_en_cours_8 branch from a7b18fd to 0f4040a Compare June 26, 2022 16:56
philippemilink
philippemilink approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

@philippemilink philippemilink merged commit dfdf6f4 into zestedesavoir:dev Jul 3, 2022
@Arnaud-D Arnaud-D deleted the passez_votre_chemin_refacto_urls_en_cours_8 branch July 4, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemilink philippemilink philippemilink approved these changes

Assignees
No one assigned
Labels
C-Back Concerne le back-end Django S-Refactorisation Améliore le code existant sans forcément ajouter de nouvelle fonctionnalité
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arnaud-D @coveralls @philippemilink