remplace :) par ;) dans emoji clin #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippemilink
approved these changes
May 11, 2022
There was a problem hiding this comment.
Merci pour cette première contribution ! :)
Quelques petites recommandations pour les prochaines fois :
- cette PR corrige le bug signalé dans le ticket Le smiley ;) insère un smiley :) #6141, donc tu peux mettre
Fix #6141dans le message de commit (ou dans le commentaire du commit) pour lier cette PR au ticket. Ainsi quand la PR sera fusionnée, le ticket sera automatiquement fermé. - ajoute les instructions de QA dans le message de la PR : comment doit-on tester la modification que tu proposes ? Là c'est simple et indiqué dans le ticket, mais c'est une bonne habitude à prendre :)
Rapport de QA
OK ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remplace :) par ;) dans smil coin
Numéro du ticket concerné :
Contrôle qualité