Empêche les notifications via les tags auxquels on est abonné pour les sujets inaccessibles

zds/notification/receivers.py

@@ -266,7 +266,7 @@ def _handle_added_tags(tag_content_type, topic):
         for subscription in subscriptions:
             notification = Notification.objects.filter(object_id=topic.id, subscription=subscription)
             if not notification:
-                if subscription.user != topic.author:
+                if subscription.user != topic.author and topic.forum.can_read(subscription.user):
                     subscription.send_notification(content=topic, sender=topic.author)
 
 

zds/notification/tests/tests_basics.py

@@ -8,7 +8,14 @@
 from django.db import IntegrityError
 
 from django.conf import settings
-from zds.forum.tests.factories import ForumCategoryFactory, ForumFactory, TopicFactory, PostFactory, TagFactory
+from zds.forum.tests.factories import (
+    ForumCategoryFactory,
+    ForumFactory,
+    TopicFactory,
+    PostFactory,
+    TagFactory,
+    create_category_and_forum,
+)
 from zds.forum.models import Topic
 from zds.gallery.tests.factories import UserGalleryFactory
 from zds.member.tests.factories import ProfileFactory, StaffProfileFactory, UserFactory
@@ -414,6 +421,28 @@ def test_notifications_on_a_tag_subscribed(self):
         notifications = Notification.objects.filter(object_id=topic2.pk, is_read=False).all()
         self.assertEqual(0, len(notifications))
 
+    def test_no_notification_on_a_tag_subscribed_in_hidden_forum(self):
+        """
+        When a user subscribes to a tag and a topic is created using that tag in a hidden forum, no notification is sent
+        """
+        # Subscribe.
+        user1 = ProfileFactory().user
+        user2 = ProfileFactory().user
+
+        group = Group.objects.create(name="Restricted")
+        user2.groups.add(group)
+        user2.save()
+        category, forum = create_category_and_forum(group)
+
+        tag1 = TagFactory(title="MyTagInHiddenForum")
+        NewTopicSubscription.objects.toggle_follow(tag1, user1)
+
+        topic1 = TopicFactory(forum=forum, author=user2)
+        topic1.add_tags([tag1.title])
+
+        notifications = Notification.objects.filter(object_id=topic1.pk, is_read=False).all()
+        self.assertEqual(0, len(notifications))
+
     def test_mark_read_a_topic_of_a_tag_subscribed(self):
         """
         When a user has a notification on a topic, the notification should be marked as read.