-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gère les utilisateurs inexistants dans RedirectOldContentOfAuthor #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippemilink
added
S-BUG
Corrige un problème
C-Back
Concerne le back-end Django
labels
Jun 5, 2022
Arnaud-D
requested changes
Jul 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques commentaires de maintenabilité seulement. La fonctionnalité fait le job comme il faut.
philippemilink
force-pushed
the
fix-old-redirect
branch
from
July 15, 2022 16:17
182e129
to
8139a07
Compare
Arnaud-D
reviewed
Jul 18, 2022
philippemilink
force-pushed
the
fix-old-redirect
branch
from
July 18, 2022 21:11
5647af8
to
ccfa809
Compare
Arnaud-D
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA OK ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La vue
RedirectOldContentOfAuthor
permet de rediriger les anciennes URLs/contenus/tutoriels/{user_pk}
vers une URL de la forme/tutoriels/voir/{user_slug}
. Cependant siuser_pk
recevait l'id d'un utilisateur inexistant, une erreur 500 était levée. Cette PR corrige ce problème et ajoute les tests pour cette vue.Problème rapporté par Sentry.
Contrôle qualité