Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gère les utilisateurs inexistants dans RedirectOldContentOfAuthor #6331

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

philippemilink
Copy link
Member

La vue RedirectOldContentOfAuthor permet de rediriger les anciennes URLs /contenus/tutoriels/{user_pk} vers une URL de la forme /tutoriels/voir/{user_slug}. Cependant si user_pk recevait l'id d'un utilisateur inexistant, une erreur 500 était levée. Cette PR corrige ce problème et ajoute les tests pour cette vue.

Problème rapporté par Sentry.

Contrôle qualité

@philippemilink philippemilink added S-BUG Corrige un problème C-Back Concerne le back-end Django labels Jun 5, 2022
@coveralls
Copy link

coveralls commented Jun 5, 2022

Coverage Status

Coverage increased (+0.06%) to 88.079% when pulling ccfa809 on philippemilink:fix-old-redirect into 143537e on zestedesavoir:dev.

Copy link
Contributor

@Arnaud-D Arnaud-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques commentaires de maintenabilité seulement. La fonctionnalité fait le job comme il faut.

zds/tutorialv2/tests/tests_views/tests_redirect.py Outdated Show resolved Hide resolved
zds/tutorialv2/views/redirect.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Arnaud-D Arnaud-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

@Arnaud-D Arnaud-D merged commit d585f02 into zestedesavoir:dev Jul 19, 2022
@philippemilink philippemilink deleted the fix-old-redirect branch July 19, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Back Concerne le back-end Django S-BUG Corrige un problème
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants