Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ajout de la syntax fix #XXXX dans le template #6338

Merged
merged 3 commits into from
Jun 19, 2022

Conversation

NightProg
Copy link
Contributor

@NightProg NightProg commented Jun 18, 2022

Fix #6308

Contrôle qualité

  • faite une nouvelle pull request
  • et voyez la nouvelle syntax Fix #XXXX

(ce n'est pas super, je pourrai le changer si vous le voulez)

@coveralls
Copy link

coveralls commented Jun 18, 2022

Coverage Status

Coverage remained the same at 87.99% when pulling fd32f52 on antoineB24:dev into 024236c on zestedesavoir:dev.

Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les petits changements que j'ai indiqués et ce sera bon ! :)

.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Arnaud-D Arnaud-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques remarques à prendre en compte pour rendre ça impeccable.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
ajout de la syntax propose de @philippemilink

Co-authored-by: Ph. SW. <philippe.milink@gmx.fr>
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

@philippemilink philippemilink enabled auto-merge (squash) June 19, 2022 15:41
@philippemilink philippemilink dismissed Arnaud-D’s stale review June 19, 2022 15:56

Corrigé par la prise en compte de ma review

@philippemilink philippemilink merged commit 57aaad8 into zestedesavoir:dev Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mettre en avant la syntaxe "Fix #XXXX" dans notre template de PR
4 participants