-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Classification par objectifs] Édition en masse des objectifs #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnaud-D
added
C-Front
Concerne l'interface du site
C-Back
Concerne le back-end Django
labels
Aug 8, 2022
Arnaud-D
force-pushed
the
mass_edit_goals
branch
4 times, most recently
from
August 11, 2022 15:01
867cf9a
to
4204097
Compare
Arnaud-D
force-pushed
the
mass_edit_goals
branch
from
August 11, 2022 15:10
4204097
to
431ce50
Compare
artragis
reviewed
Aug 11, 2022
Sur la béta, j'ai un beau glitch graphique : https://cdn.discordapp.com/attachments/547038766506967041/1010258565925175346/unknown.png |
Arnaud-D
force-pushed
the
mass_edit_goals
branch
from
September 1, 2022 18:22
b7eb9fa
to
51cc9b1
Compare
J'ai corrigé les remarques qui ont été faites. |
c'est opé pour moi ! on peut merger |
artragis
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C'est prêt !
L'idée est de réaliser une page qui accélère la gestion de la classification par objectifs, en particulier au démarrage (près de 1400 publications à passer en revue !). Du point de vue de l'utilisateur, c'est une grande liste des publications avec des filtres et des boutons pour activer/désactiver un objectif donné pour chaque contenu. Techniquement, ça envoie des requêtes de manière asynchrone, sur le modèle des demandes d'aides.
Il y a une de la réutilisation du code des demande d'aides pour le front, après une menue refactorisation.
Contrôle qualité
Ne pas oublier d'appliquer les migrations.
Non-régression : tester le bon fonctionnement des demandes d'aides
Avant de passer à la suite : ajuster le paramère "goals_content_per_page" pour voir la pagination.
Fonctionnalité principale :
Permissions à tester :