Corrige la route pour dissocier un ticket GitHub d'un sujet du forum #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arnaud-D
requested changes
Aug 14, 2022
zds/forum/tests/tests_views.py
Outdated
Comment on lines
1930
to
1977
| class ManageGitHubIssueTest(TestCase): | ||
| def test_show_links(self): | ||
| """ | ||
| Test if buttons to manage GitHub issues are correctly displayed according to the context. | ||
| """ | ||
| profile = ProfileFactory() | ||
| dev_profile = DevProfileFactory() | ||
| category, forum = create_category_and_forum() | ||
| unlinked_topic = create_topic_in_forum(forum, profile) | ||
| linked_topic = create_topic_in_forum(forum, profile) | ||
| linked_topic.github_repository_name = settings.ZDS_APP["github_projects"]["repositories"][0] | ||
| linked_topic.github_issue = 42 | ||
| linked_topic.save() | ||
|
|
||
| route = "forum:topic-posts-list" | ||
| label_linked_issue = _("Ticket associé") | ||
| label_unlink_issue = _("Dissocier le ticket") | ||
| label_create_issue = _("Créer un ticket") | ||
| label_link_issue = _("Associer un ticket") | ||
|
|
||
| # Default: nothing is displayed | ||
| response = self.client.get(reverse(route, args=[unlinked_topic.pk, unlinked_topic.slug()])) | ||
| self.assertNotContains(response, label_linked_issue) | ||
| self.assertNotContains(response, label_unlink_issue) | ||
| self.assertNotContains(response, label_create_issue) | ||
| self.assertNotContains(response, label_link_issue) | ||
|
|
||
| # An issue is associated: the link is displayed | ||
| response = self.client.get(reverse(route, args=[linked_topic.pk, linked_topic.slug()])) | ||
| self.assertContains(response, label_linked_issue) | ||
| self.assertNotContains(response, label_unlink_issue) | ||
| self.assertNotContains(response, label_create_issue) | ||
| self.assertNotContains(response, label_link_issue) | ||
|
|
||
| # Logged as a dev member, no ticket is associated: buttons to link or create an issue are displayed | ||
| self.client.force_login(dev_profile.user) | ||
| response = self.client.get(reverse(route, args=[unlinked_topic.pk, unlinked_topic.slug()])) | ||
| self.assertNotContains(response, label_linked_issue) | ||
| self.assertNotContains(response, label_unlink_issue) | ||
| self.assertContains(response, label_create_issue) | ||
| self.assertContains(response, label_link_issue) | ||
|
|
||
| # Logged as a dev member, a ticket is associated: buttons to unlink or view the issue are displayed | ||
| response = self.client.get(reverse(route, args=[linked_topic.pk, linked_topic.slug()])) | ||
| self.assertContains(response, label_linked_issue) | ||
| self.assertContains(response, label_unlink_issue) | ||
| self.assertNotContains(response, label_create_issue) | ||
| self.assertNotContains(response, label_link_issue) |
There was a problem hiding this comment.
Je pense que c'est mieux de séparer les différents cas. En fait, tes commentaires délimitent les cas qui devraient être dans des tests individuels. Et ce qui est au début de la fonction est le setUp. ^^
philippemilink
force-pushed
the
fix-url
branch
from
3c165f2
to
ca34338
Compare
Arnaud-D
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR corrige la route pour dissocier un ticket GitHub d'un sujet du forum (probablement un oubli lors de la refactorisation des URLs) et ajoute un test pour s'assurer que ce genre de problème ne passe plus sous nos radars.
Problème rapporté par Sentry.
QA
Le plus simple est sans doute de faire une revue de code et de constater que le changement principal est correct et ne peut pas introduire de bug, sinon il est possible que je déploie cette PR sur la bêta. Si #6377 est fusionné lors de la QA, il est aussi possible modifier les champs Ticket GitHub (avec n'importe quelle valeur) et Nom du dépôt GitHub (par une des valeurs des dépôts définies dans la configuration) et en tant qu'utilisateur
dev, aller sur la page du sujet et constater qu'elle s'affiche correctement.