Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrige le domaine pour les placeholders des Unes #6406

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

Arnaud-D
Copy link
Contributor

Le nom de domaine pour les placeholders a changé il y a quelque temps, donc on ne pouvait plus charger les images utilisées en Une sur l'environnement de dév. C'est désormais corrigé.

Contrôle qualité

Charger les unes depuis les fixures et constater qu'elles sont bien affichées : Five, Four, Three, Two, One.

@Arnaud-D Arnaud-D added the C-DevelopmentEnv Amélioration de l'environnement de dev label Oct 20, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.318% when pulling 20242f8 on Arnaud-D:placeholder-dev into 2bc47e7 on zestedesavoir:dev.

@Arnaud-D Arnaud-D added the hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest label Oct 20, 2022
Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK

@Situphen Situphen merged commit fcb162e into zestedesavoir:dev Oct 24, 2022
@Arnaud-D Arnaud-D deleted the placeholder-dev branch October 24, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-DevelopmentEnv Amélioration de l'environnement de dev hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants