Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrige un détail de CSS pour la neige #6442

Merged
merged 2 commits into from
Jan 15, 2023

Conversation

Situphen
Copy link
Member

L'entête du site web est bleue mais avec un très léger gradient qui fait que son centre est plus clair que ses côtés. Actuellement, le code JS qui gère la neige rend transparent l'entête et applique la bonne couleur de fond au canvas qui gère la neige, mais sans le gradient. Lors du chargement de la neige sur la page, il y a donc un changement de couleur très léger mais énervant. Cette PR corrige ce soucis en appliquant au canvas la bonne couleur de fond et le gradient de couleur.

QA :

  • source zdsenv/bin/activate && make update && make zmd-start && make run
  • Activer la neige
    diff --git a/zds/settings/dev.py b/zds/settings/dev.py
    index 1f2c2e223..972f3a7af 100644
    --- a/zds/settings/dev.py
    +++ b/zds/settings/dev.py
    @@ -82,3 +82,5 @@ ZDS_APP["very_top_banner"] = {
         "message": "Version locale",
         "slug": "version-locale",
     }
    +
    +ZDS_APP["visual_changes"] = ["snow"]
  • Vérifier lors du chargement de la page que la couleur de l'entête ne varie pas

@Situphen Situphen added the C-Front Concerne l'interface du site label Dec 26, 2022
@coveralls
Copy link

coveralls commented Dec 26, 2022

Coverage Status

Coverage: 88.296%. Remained the same when pulling 319608d on Situphen:snow-fix into 7e59f7a on zestedesavoir:dev.

Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

@philippemilink philippemilink enabled auto-merge (squash) January 15, 2023 14:57
@philippemilink philippemilink merged commit 6d62a7b into zestedesavoir:dev Jan 15, 2023
@Situphen Situphen deleted the snow-fix branch January 15, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Front Concerne l'interface du site
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants