Utilise package-lock pour ZMarkdown #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visiblement, il y a un problème dans une des dépendances de ZMarkdown, comme la CI me l'a montré aujourd'hui. Je n'avais pas le problème en local, mais je parviens à reproduire le problème si je repars d'une installation fraîche de zds-site.
Je me suis rendu compte qu'on n'utilise pas de fichier
package-lock.jsonpour ZMarkdown, qui permet de figer les versions utilisées de toutes les dépendances et de se retrouver avec des mauvaises surprises comme celle-ci.Cette PR ajoute un fichier
package-lock.jsonpour ZMarkdown. J'ai utilisé celui-qui a été généré sur le serveur de bêta lors du dernier déploiement (il y a deux semaines), donc il est suffisamment récent, mais pas trop récent pour inclure aussi le bug.Contrôle qualité
make zmd-stop make zmd-install make zmd-start python manage.py test zds.forum.tests --settings zds.settings.testLa dernière ligne faisait apparaître le bug.