Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire les usages du templatetag obsolète {% ifnotequal %} (préparation pour Django 4) #6534

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Retire les usages du templatetag obsolète {% ifnotequal %} (préparation pour Django 4) #6534

merged 2 commits into from
Oct 1, 2023

Conversation

Arnaud-D
Copy link
Contributor

@Arnaud-D Arnaud-D commented Oct 1, 2023 •
edited
Loading

Le template tag {% ifnotequal %} est obsolète dans notre version de Django et sera retiré dans Django 4.

J'ai fait la correction recommandée, à savoir utiliser {% if %}, qui remplit tous les cas d'usage que faisait cet ancien templatetag.

Contrôle qualité

  • CI
  • lancer le site et vérifier que ça marche à droite à gauche
  • vérifier spécifiquement les pages avec de la pagination, vu que ça touche ses parties-là.

@Arnaud-D Arnaud-D added the C-Back Concerne le back-end Django label Oct 1, 2023
@coveralls
Copy link

coveralls commented Oct 1, 2023 •
edited
Loading

Coverage Status

coverage: 88.413%. remained the same when pulling f0259b4 on Arnaud-D:prepa-django4-ifnotequal into fb54169 on zestedesavoir:dev.

Situphen
Situphen reviewed Oct 1, 2023
View reviewed changes
Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ! Je n'ai pas décelé de soucis lors de ma navigation.

@Situphen Situphen enabled auto-merge (rebase) October 1, 2023 13:28
@Situphen Situphen merged commit ae460de into zestedesavoir:dev Oct 1, 2023
8 checks passed
@Arnaud-D Arnaud-D deleted the prepa-django4-ifnotequal branch October 1, 2023 13:44
@Arnaud-D Arnaud-D added the hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Situphen Situphen Situphen approved these changes

Assignees
No one assigned
Labels
C-Back Concerne le back-end Django hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arnaud-D @coveralls @Situphen