Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passage à Node.js 18 LTS #6535

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Conversation

Situphen
Copy link
Member

@Situphen Situphen commented Oct 1, 2023

Passage à Node.js 18 LTS car Node.js 16 LTS n'est plus supporté depuis 3 semaines

Instructions pour la mise à jour :

  • nvm install (pour installer Node.js 18)
  • npm -g add yarn (pour installer Yarn dans le nouvel environnement)
  • make install-front

QA : Github Actions + vérifier que le site web fonctionne bien en local

@coveralls
Copy link

coveralls commented Oct 1, 2023

Coverage Status

coverage: 88.562% (-0.02%) from 88.579% when pulling abe54cc on Situphen:nodejs-update into f6aab38 on zestedesavoir:dev.

Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

À noter que nvm install ne parvenait pas à trouver la version 18, il a fallu que je mette à jour nvm en lançant ./scripts/install_zds.sh +node.

@philippemilink philippemilink merged commit 9665507 into zestedesavoir:dev Oct 8, 2023
8 checks passed
@Arnaud-D
Copy link
Contributor

Arnaud-D commented Oct 8, 2023

J'ai pas eu ton souci, je devais avoir une version plus récente déjà installée.

@Arnaud-D Arnaud-D added the hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest label Oct 8, 2023
philippemilink added a commit to philippemilink/zds-site that referenced this pull request Oct 8, 2023
Arnaud-D pushed a commit that referenced this pull request Oct 8, 2023
@Situphen Situphen deleted the nodejs-update branch October 8, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull request approuvée pour le Hacktoberfest
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants