Remplace la méthode obsolète request.is_ajax (préparation pour Django 4) #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Situphen
previously requested changes
Oct 1, 2023
Arnaud-D
force-pushed
the
prepa-django4-is_ajax
branch
2 times, most recently
from
c4115ad
to
35f4898
Compare
artragis
reviewed
Oct 1, 2023
Arnaud-D
added
the
hacktoberfest-accepted
Arnaud-D
force-pushed
the
prepa-django4-is_ajax
branch
from
35f4898
to
8d12abf
Compare
Arnaud-D
force-pushed
the
prepa-django4-is_ajax
branch
from
8d12abf
to
901a799
Compare
Arnaud-D
force-pushed
the
prepa-django4-is_ajax
branch
from
901a799
to
e70c5aa
Compare
philippemilink
approved these changes
Oct 8, 2023
philippemilink
dismissed
Situphen’s stale review
Aabu a corrigé et ça empêche de merger :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR fait partie de modifications nécessaires pour passer à Django 4.
On utilise régulièrement
request.is_ajax()pour savoir si la requête provient du frontend de manière asynchrone, etc. Django a décidé que la méthode de détection était trop spécifique à JQuery et a décidé de supprimer la méthode dans Django 4. Une correction simple est de créer sa propre fonction qui reprend la même logique, ce que j'ai fait. C'est aussi une des solutions recommandées.J'ai corrigé une coquille dans un truc qui n'a rien à voir au passage. Ne pas squasher au merge, ça sera mieux pour ne pas tout mélanger.
Contrôle qualité