Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajoute un formulaire pour modifier les catégories d'une publication #6603

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Ajoute un formulaire pour modifier les catégories d'une publication #6603

merged 10 commits into from
Apr 26, 2024

Conversation

Arnaud-D
Copy link
Contributor

@Arnaud-D Arnaud-D commented Apr 6, 2024 •
edited
Loading

Actuellement, la modification des catégories est dans un formulaire fourre-tout. Cette PR déplace ce choix dans un formulaire dédié. On y accède par un bouton, comme pour les formulaires de licence.

image

image

Fix #5908

Contrôle qualité

  • Créer des contenus.
  • Assigner des catégories, en supprimer.
  • Demander la validation avec des catégories, sans catégories.
  • Essayer de retirer toutes les catégories d'une publication publique.

@Arnaud-D Arnaud-D added C-Front Concerne l'interface du site C-Back Concerne le back-end Django labels Apr 6, 2024
@coveralls
Copy link

coveralls commented Apr 6, 2024 •
edited
Loading

Coverage Status

coverage: 88.786% (+0.03%) from 88.752%
when pulling 985f21a on Arnaud-D:formulaire-categorie
into 7b70da3 on zestedesavoir:dev.

@Arnaud-D Arnaud-D marked this pull request as ready for review April 7, 2024 18:51
philippemilink
philippemilink requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une petite ligne à supprimer, un rebase est on est bon

templates/tutorialv2/edit/categories.html Outdated Show resolved Hide resolved
@Arnaud-D
Copy link
Contributor Author

Changements pris en compte.

philippemilink
philippemilink requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En fait il y a encore deux lignes inutiles (désolé de ne pas l'avoir remarqué lors de ma première revue).

templates/tutorialv2/edit/categories.html Outdated Show resolved Hide resolved
templates/tutorialv2/includes/headline/categories.part.html Outdated Show resolved Hide resolved
Arnaud-D and others added 2 commits April 25, 2024 22:11
@Arnaud-D @philippemilink
Update templates/tutorialv2/edit/categories.html
a4258d1 
Co-authored-by: Ph. SW. <philippe.milink@gmx.fr>
@Arnaud-D @philippemilink
Update templates/tutorialv2/includes/headline/categories.part.html
985f21a 
Co-authored-by: Ph. SW. <philippe.milink@gmx.fr>
philippemilink
philippemilink approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

@philippemilink philippemilink merged commit f98b5b7 into zestedesavoir:dev Apr 26, 2024
12 checks passed
@Arnaud-D Arnaud-D deleted the formulaire-categorie branch April 28, 2024 05:52
@Arnaud-D Arnaud-D mentioned this pull request May 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemilink philippemilink philippemilink approved these changes

Assignees
No one assigned
Labels
C-Back Concerne le back-end Django C-Front Concerne l'interface du site
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Déplacer le choix des catégories d'une publication dans un formulaire dédié
3 participants
@Arnaud-D @coveralls @philippemilink