Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update space -> ad unit naming, misc fixes #170

Merged
merged 9 commits into from
Apr 20, 2023
Merged

Update space -> ad unit naming, misc fixes #170

merged 9 commits into from
Apr 20, 2023

Conversation

msub2
Copy link
Contributor

@msub2 msub2 commented Apr 18, 2023

  • Updates the wording of space to be ad unit instead
  • Removes a URL redirect on default banner CTA urls
  • Updates some JSDoc comments

limbofeather
limbofeather approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@limbofeather limbofeather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msub2 msub2 merged commit 7fb77a6 into v2 Apr 20, 2023
@msub2 msub2 deleted the naming-and-misc-fixes branch April 20, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limbofeather limbofeather limbofeather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msub2 @limbofeather